sakrejda
commented
8 years ago Yeah, I accidentally turned it off on the last two pull requests. When I fix up my code I'll work on the lint problems. Thanks for taking care of so much of the code quality and makefile stuff, I don't think you're doing your efforts justice when you say you're watching me develop this repo! On Mar 8, 2016 3:52 PM, "Allen Riddell" notifications@github.com wrote:
PRs should now be checked for cpplint.
Added -whitespcae/line_length since many lines currently violate it. (120
characters also seems better to me.)
You can view, comment on, or merge this pull request online at:
https://github.com/sakrejda/protostan/pull/51 Commit Summary
- Run cpplint on travis
- Add -whitespace/line_length to cpplint filters
- cpplint: fix cpplint complaints
File Changes
- M .travis.yml https://github.com/sakrejda/protostan/pull/51/files#diff-0 (4)
- M Makefile https://github.com/sakrejda/protostan/pull/51/files#diff-1 (8)
- M src/protostan/interface_callbacks/writer/binary_proto_stream_writer.hpp https://github.com/sakrejda/protostan/pull/51/files#diff-2 (14)
- M src/protostan/util/rw_delimited_pb.hpp https://github.com/sakrejda/protostan/pull/51/files#diff-3 (11)
Patch Links:
- https://github.com/sakrejda/protostan/pull/51.patch
- https://github.com/sakrejda/protostan/pull/51.diff
— Reply to this email directly or view it on GitHub https://github.com/sakrejda/protostan/pull/51.
ariddell
PRs should now be checked for cpplint.
Added -whitespcae/line_length since many lines currently violate it. (120 characters also seems better to me.)