sakrejda / protostan

Thin protobuf interface wrapper for Stan
BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

Use gRPC #56

Closed arthur-tacca closed 7 years ago

arthur-tacca commented 7 years ago

This project would be more useful if it used gRPC as the serialisation / message handling layer instead of the manual length-prefixed serialisation code it currently uses. The change would not be that fundamental, as gRPC is also based on Protocol Buffers.

Benefits:

arthur-tacca commented 7 years ago

Sorry. Immediately after posting this issue I had a further look around the repo and noticed compile-grpc.proto, so you're already at least considering this. I would delete this issue if I could but I don't seem to have that option, so I'll just close it instead.

sakrejda commented 7 years ago

Thanks for taking a look. I've been messing around with this mostly to have a good sense of what it would look like if implemented for real. There's another repo on my account somewhere that does a little server using gRPC. I think long term it will be a good idea but for the moment there's a lot of movement internally in Stan sorting out I/O and related format issues so it would be a lot of work to develop this and track the changes coming in Stan. Feel free to get in touch directly if expanding this project is relevant to you.