search

sakshamj74 / IPL-Analysis

The aim of the project is to analyze the previous year's IPL data to get some interesting insights.
7 stars 22 forks source link

Highest score of team in each season #21

Closed Halix267 closed 3 years ago

Halix267 commented 3 years ago

closes #6 Highest team score each season

Halix267 commented 3 years ago

@sakshamj74 I have made the changes in Delieveries.ipynb.Plzz review it.

sakshamj74 commented 3 years ago

Hey, you have plotted the highest team totals each season and in legends, it is showing Batsman's name. Please correct it.

Halix267 commented 3 years ago

Ok ok sorry i will correct it

sakshamj74 commented 3 years ago

@Halix267 Please don't be sorry. It happens. Guyz please make a separate file of what you are working on Because it is getting difficult to keep track of things as we are all working on the same files. So you can keep the file name related to the task you have performed in the notebook. Like if you are working on top bowlers you can keep the filename as "top_bowlers.ipynb"

Halix267 commented 3 years ago

@sakshamj74 I have corrected the code . Plzz review it.

Halix267 commented 3 years ago

@sakshamj74 .Can u tell me when will u assign the points of this pr , If u already assigned the points, but u give me 5 points for this pr as it was the intermediate issue.