[Fixes #5] Added top 5 all rounders

[Vrindagupta6828]

fixes #5

[Vrindagupta6828]

@sakshamj74 Please review my pr.

[sakshamj74]

@Vrindagupta6828 Please review your code once again because R Sharma and V Kohli in top all-rounders are a bit strange. Moreover,,in #5 @Player0109 also uploaded some graphs with some criteria as you r(min 1000 runs and 40 wickets) and results are different.

[Vrindagupta6828]

@sakshamj74 I know but i also performed the analysis and only this is coming you can check all the calculations

[sakshamj74]

@Vrindagupta6828 Let me check this again

[Vrindagupta6828]

@sakshamj74 yes sure..thank you

[Vrindagupta6828]

@sakshamj74 Did you check?

[sakshamj74]

@Vrindagupta6828 I haven't checked yet.I Will let you know tomorrow.

[sakshamj74]

@Vrindagupta6828 I analyzed your code. Actually, notice the last line in this ss. In this you are just printing batsmen with >=1000 runs not updating your data frame which you will be using later. So you must chnage this line to top_batsmen=top_batsmen[top_batsmen.runs>=1000] Similar is the case with bowlers. That is why we are getting incorrect results.

[sakshamj74]

@Vrindagupta6828 After corrections, I am getting something like this (min 1000 runs and 50 wickets).

Please do the necessary corrections and remove this code from deliveries.ipynb and make a separate file for this as we will be working more on this.

[Vrindagupta6828]

@sakshamj74 sure and what should i name that file?

[sakshamj74]

@Vrindagupta6828 Anything related to the task you will be doing like "top_5_all_rounders.ipynb"

[Vrindagupta6828]

@sakshamj74 Raised another pr please review it.