search

sakshamj74 / IPL-Analysis

The aim of the project is to analyze the previous year's IPL data to get some interesting insights.
7 stars 22 forks source link

matches held every season #59

Closed uddeshyatyagi closed 3 years ago

uddeshyatyagi commented 3 years ago

closes #58

sakshamj74 commented 3 years ago

@uddeshyatyagi Make a separate file and move your code to that file .

uddeshyatyagi commented 3 years ago

@sakshamj74 ,code has been moved to a separate file, please review !!

sakshamj74 commented 3 years ago

@uddeshyatyagi Also remove your code from Matches.ipynb

uddeshyatyagi commented 3 years ago

@sakshamj74, i already removed my code from matches.ipynb, has only added code in a separate file afaik !!

uddeshyatyagi commented 3 years ago

Screenshot from 2020-12-14 16-39-47 Screenshot from 2020-12-14 16-39-56

@sakshamj74 in this screenshot you can clearly see that i have only added my code in a separate file and not in matches.ipynb

If there is something which is not okay then please tell me about that again ,have a word of conversation,explain it to me,but don't stay quite for 5-6 days or so. Thank you !

sakshamj74 commented 3 years ago

Hey, @uddeshyatyagi Will figure it out by today.