sakshamj74 / IPL-Analysis

The aim of the project is to analyze the previous year's IPL data to get some interesting insights.
7 stars 22 forks source link

[Fixes #50] Added toss winners #99

Closed Vrindagupta6828 closed 3 years ago

Vrindagupta6828 commented 3 years ago

What is the change?

I added the analysis of teams that win and the tosses won by them

What does it fix/add?

I analyzed matches.csv

How was it tested?

It was tested by toss-winners column

Submissions guide:

[x] Have you followed the Contribution guide? [ x] Have you checked to ensure there aren't other open Pull Requests for the same update/change? [ x] Have you made corresponding changes to the documentation? [ x] Your submission doesn't break any existing feature. [ x] Have you lint your code locally prior to submission?

Screenshots (if appropriate):

toss

Vrindagupta6828 commented 3 years ago

@sakshamj74 Please review my pr. I have solved the error sorry for the inconvenience.

sakshamj74 commented 3 years ago

@Vrindagupta6828 One more thing what the numbers on the x-axis specify?

Vrindagupta6828 commented 3 years ago

@Vrindagupta6828 One more thing what the numbers on the x-axis specify?

the teams are encoded should i add a key?

sakshamj74 commented 3 years ago

@Vrindagupta6828 One more thing what the numbers on the x-axis specify?

the teams are encoded should i add a key?

Yes, it will be easy to interpret.

Vrindagupta6828 commented 3 years ago

Ok

Vrindagupta6828 commented 3 years ago

Capture @sakshamj74 Is this ok this way as i am unable to plot a table out of a dict.

Vrindagupta6828 commented 3 years ago

@sakshamj74 Can you please tell me how much points you have assigned to me for this issue?