search

sakuli / sakuli.github.io

Web Page for Sakuli
https://sakuli.io
3 stars 3 forks source link

Add domain for "now" deplyoments to CORS-Rules #100

Closed tnobody closed 4 years ago

tnobody commented 5 years ago

As a developer/reviewer i would like to see a online preview of a PR that behaves like the normal deployed website. Therefore the content from remote pages (consol.de / consol.com) have to be loaded without CORS-issues.

Additional Information

PRs are deployed on [https://zeit.co/home]. With the following url schema: https://[PR-TITLE].s1hofmann.now.sh/. To allow this pages to load contents from consol.com a cors rul have to be added on consol.com. the rule should allow all request from *.s1hofmann.now.sh.

Additionally we could think about a wildcard for something like *.sakuli.now.sh/ or *.sakuli-io.now.sh/ when we create a dedicated sakuli account on zeit.co for sakuli.

ZNicoZ commented 5 years ago

Requested cors enhancement at Consol

ZNicoZ commented 5 years ago

*.s1hofmann.now.sh added to CORS

image.png

tnobody commented 5 years ago

Can also confirm for https://sakuligithubio-git-develop.s1hofmann.now.sh/enterprise

So I'll move this issue to done.

tnobody commented 4 years ago

Since our page repor doesn't follow the realease cycle of sakuli I move this issue to closed and close it.