search

sakura-ryoko / malilib

Library mod for masa's client-side Minecraft mods
GNU Lesser General Public License v3.0
355 stars 22 forks source link

malilib 1.21.3 (0.22.0/sakura.7) doesnt work with lunar client #24

Closed ForbiddenTexts closed 1 week ago

ForbiddenTexts commented 2 weeks ago

crash-2024-11-20_02.24.23-client.txt

crashes upon initialization, when using Lunar client 1.21.3

sakura-ryoko commented 2 weeks ago

In my experience these problems are usually a lunar client problem; and from the error log they are rejecting a "Normal" mixin injection into the world; because Lunar Client is hacking things into the World Rendering where they probably shouldn't for a Client.

sakura-ryoko commented 1 week ago

Also, the way I crafted these Mixins was to do minimal (Next to nothing) changes to Vanilla for the MaLiLib world rendering hooks by adding MaLiLib's own "World RenderPass" phases. This is very brittle code in the sense of things breaking if any changes whatsoever are made, and will not be changed.

Lunar broke it, so it's their job to fix it. Not mine. Launchers should not be making such changes to the Vanilla game.

ForbiddenTexts commented 1 week ago

Thanks for the explanation