sakura-ryoko / minihud

A client-side Minecraft mod with configurable "info lines" ("mini-F3") and various overlays, such as light level and structure bounding boxes
GNU Lesser General Public License v3.0
256 stars 14 forks source link

Severe memory leak leading to crash when open the display of villager information(overlayVillagerInfo) #48

Open Hx-zh opened 3 weeks ago

Hx-zh commented 3 weeks ago

turn on mod version:minihud-fabric-1.21-0.31.999-sakura.19 Fabric&minecraft version:1.21.1-Fabric 0.15.11 When I turn on this feature, with some villagers selling enchanting books , I can observe in the task manager that the memory occupied by the Java process is increasing rapidly.(more than 1MB/s) After a period of time, this will cause the game to crash

and here are my mod list

architectury-13.0.6-fabric.jar
fabric-api-0.102.1+1.21.1.jar
fabric-language-kotlin-1.12.0+kotlin.2.0.10.jar
ftb-library-fabric-2100.1.4.jar
ftb-ultimine-fabric-2100.1.0.jar
itemscroller-fabric-1.21-0.24.0.jar
libIPN-fabric-1.21-6.0.2.jar
litematica-fabric-1.21-0.19.0.jar
malilib-fabric-1.21-0.20.2.jar
minihud-fabric-1.21-0.31.999-sakura.19.jar
placeholder-api-2.4.1+1.21.jar
syncmatica-fabric-1.21-0.3.12-sakura.3.jar
tweakeroo-fabric-1.21-0.20.999-sakura.22.jar
YetAnotherConfigLib-3.5.0+1.21-fabric.jar
Zoomify-2.14.0+1.21.jar
gugle-carpet-addition-mc1.21-2.9.0+build.52.jar
jei-1.21-fabric-19.8.2.99.jar
XaerosWorldMap_1.38.8_Fabric_1.21.jar
Xaeros_Minimap_24.2.1_Fabric_1.21.jar
InventoryProfilesNext-fabric-1.21-2.0.4.jar
CustomSkinLoader_Fabric-14.20.jar
fabric-carpet-1.21-1.4.147+v240613.jar
litematica-printer-1.21-3.5.0-sakura.4.jar
modmenu-11.0.1.jar
toms_storage_fabric-1.21-2.0.9.jar
shulkerboxtooltip-fabric-5.0.4+1.21.jar
inventoryhud.fabric.1.21-3.4.24.jar
Jade-1.21-Fabric-15.1.5.jar
appleskin-fabric-mc1.21-3.0.5.jar
jecharacters-fabric-4.5.14.jar
sodium-extra-0.5.7+mc1.21.jar
sodium-fabric-0.5.11+mc1.21.jar
pinyined-masa-0.6.jar
sakura-ryoko commented 2 weeks ago

Can you post the actual crash log ? Also, are you on a server, and I am assuming that it doesn't have Servux installed, and you are not OP ?

Hx-zh commented 2 weeks ago

1.Unfortunately,when the memory leaks completely, it will cause my launcher to crash and unable to collect crash logs. I will try to collect more information later. 2.Both local and server have this issue . By the way ,I am OP and there is no difference in the phenomenon before and after installing Servux.

sakura-ryoko commented 2 weeks ago

Can you update your mods to the latest versions and try to reproduce ?

Hx-zh commented 2 weeks ago

update to minihud-fabric-1.21-0.31.999-sakura.23.jar and use a new package , Here is my file list

fabric-api-0.102.1+1.21.1.jar
malilib-fabric-1.21.1-0.21.0.jar
minihud-fabric-1.21-0.31.999-sakura.23.jar

After hanging up for a period of time, reproduce the memory leak but no crash. Memory usage returns to normal after reaching a very high level. The memory usage of Java processes once reached 9GB. The overall memory usage rate is 91%. Perhaps other factors are needed to cause the game to crash. For example, there may be changes in the memory occupied by player activities or other backend applications.

Although there was no game crash, I believe such a severe memory leak is very dangerous, as it initially caused my backend chat software to crash image

sakura-ryoko commented 2 weeks ago

Is this happening with ONLY those 3 mods installed, or do you have other mods still installed? If so, try removing them and seeing if you can reproduce it.

Hx-zh commented 2 weeks ago

ONLY