search

sakura-ryoko / minihud

A client-side Minecraft mod with configurable "info lines" ("mini-F3") and various overlays, such as light level and structure bounding boxes
GNU Lesser General Public License v3.0
258 stars 14 forks source link

[Bug] Rendering Incompatibility with Polymer Mods on Servers #52

Open borisshoes opened 2 weeks ago

borisshoes commented 2 weeks ago

Polymer is a framework used by Server-Sided mods to allow custom item implementation only on the server side. Polymer-implemented custom items are sent as a vanilla minecraft item stand-in to clients, usually with a CustomModelData flag to be used in conjunction with a resource pack.

Having MiniHud enabled while playing on a server with polymer-based mods causes any polymer-based items to disappear from rendering when being put in an item frame, held by another player, or worn as armor. Using Freecam from Tweakaroo also causes all of the above to happen instantly to all rendered polymer items, on top of causing any items in the players hotbar and inventory to no longer render.

Demonstration: https://youtu.be/IJ3uOBPBkHU

sakura-ryoko commented 2 weeks ago

I have spoken with Patbox about this issue, and the problem seems to be related to MiniHUD (And Tweakeroo / Litematica)'s implementation of how their entity_data_sync protocols function. They are currently Overwriting your modded items' data.

Let me know if the problem still happens if you completely disable the entity_data_sync features of all 3 of these mods.

borisshoes commented 2 weeks ago

Thanks for the information! I have found that the bug occurs for only OP'd players when Servux is not installed on the server, but for all players when Servux is installed. The settings in Tweakaroo and Litematica seem irrelevant to causing the bug. Changing the EntityDataSync features on MiniHUD stops the bug completely when selecting the correct setting for whether or not the server has Servux installed. Will I lose any important functionality of MiniHUD leaving data sync disabled? Also, I hate to ask, but would you consider a compatibility patch at some point?

sakura-ryoko commented 2 weeks ago

Yes, your Info Lines Server Entity Data (Such as Looking At Entity, and Beehives, etc), and inventory Preview features in MiniHUD will fail to function without the entity_data_sync features enabled.