search

sakura-ryoko / servux

A server-side Minecraft mod that sends data to and provides some other integration with masa's client-side mods
GNU Lesser General Public License v3.0
36 stars 2 forks source link

feat: new packet types #2

Closed zly2006 closed 3 months ago

zly2006 commented 3 months ago

To work together with litematica, should be merged after litematica stuff was built up

zly2006 commented 3 months ago

servux side code for https://github.com/sakura-ryoko/litematica/pull/3 is here.

sakura-ryoko commented 3 months ago

Is this all ready for review ?

zly2006 commented 3 months ago

NOTE: This PR still need some improvements such as permission and rate limiting stuff, but if you want to help implement that stuff it is ready to merge

sakura-ryoko commented 3 months ago

NOTE: This PR still need some improvements such as permission and rate limiting stuff, but if you want to help implement that stuff it is ready to merge

I have plans to add lucko permissions API for the various Data Provider's, and a config setting for allowing players to use them. I have done these features before under my other mods; so I understand how lucko permissions works.

sakura-ryoko commented 3 months ago

Luck Permissions nodes added, and a "default permissions level", and added a new Config File handling for each Data Provider; so that they can individually restrict their use to a Permissions level (In addition to the Luck Perms nodes)

The default being that anyone can use them.

sakura-ryoko commented 3 months ago

Also, what do you mean by "rate limiting" ? Like rate Limiting a packet or paste operations ?

zly2006 commented 3 months ago

Also, what do you mean by "rate limiting" ? Like rate Limiting a packet or paste operations ?

Yes, because that might cause excessive network traffic, or server lag, so for example, the server only respond 10 nbt queries per tick, and the player can only paste 2 litematica in a second, etc.

sakura-ryoko commented 3 months ago

Okay I see