sakura-ryoko / servux

A server-side Minecraft mod that sends data to and provides some other integration with masa's client-side mods
GNU Lesser General Public License v3.0
47 stars 2 forks source link

Feat: structure blacklst and whitelist #8

Closed zly2006 closed 3 months ago

zly2006 commented 3 months ago

You dont need the old default permission stuff. You can just create a class for the config, with default values. it should be totally removed later.

sakura-ryoko commented 3 months ago

I was following the original JSON methodology from other mods. Fortunately I am familiar with the GSON syntax, so I know what you are doing here. My "corelib" mod that I've been working on uses a similar Config handler method via GSON. But question, where are the ServixConfig.class files ?

sakura-ryoko commented 3 months ago

Ohh I see, it's an inner-class 🤣

sakura-ryoko commented 3 months ago

Eventually I want to extend the /servux command like we talked about, with a Config Validator wrapper; sort of like how Carpet Mod works, but lots of work needs to be done for this.

What I've done so far, was to lay out the frame work / ideas. The command interface is also meant to be converted into an extendable Interface for registering commands, for mods that use Servux as a server-side library mod, at some point.

Then perhaps in the future, the Data Provider's can be more of a 'module' system.

zly2006 commented 3 months ago

Eventually I want to extend the /servux command like we talked about, with a Config Validator wrapper; sort of like how Carpet Mod works, but lots of work needs to be done for this.

What I've done so far, was to lay out the frame work / ideas. The command interface is also meant to be converted into an extendable Interface for registering commands, for mods that use Servux as a server-side library mod, at some point.

Then perhaps in the future, the Data Provider's can be more of a 'module' system.

OK I ll do this in another PR

sakura-ryoko commented 3 months ago

I'll merge it for now

sakura-ryoko commented 3 months ago

I was also doing something with the whitelist / blacklist back in the 1.20.6 branch under snapshot, but it was syncing the settings from the clients. I removed all of that code previously for simplicity.