Rare bug causing weapons to "jam"

sakura57 / so4

Spaced Out 4, an open-source 2D space shooter game

GNU General Public License v2.0

1 stars 0 forks source link

Closed sakura57 closed 4 years ago

sakura57 commented 4 years ago

Version latest

Description Occasionally, weapons will refuse to fire. This lasts for the entire time a player is in space.

Steps To Reproduce

In space, attempt to fire weapons. Seems to happen randomly, and more often with missiles than guns.

sakura57 commented 4 years ago

Seems there are several culprits:

Uninitialized member variable CWeaponInstance::m_flRefireTimeRemaining
Another uninitialized variable, WeaponArch::flEnergyCost which gets tested in CEquippedObject::fire_weapons_if_ready

sakura57 commented 4 years ago

Fixed with 1e3f0c187351a4ed4a5a1d054aacf241b5296241