search

sakurity / securelogin

This version won't be maintained!
MIT License
1.22k stars 35 forks source link

Begin to clean up JavaScript #31

Closed andrewda closed 7 years ago

andrewda commented 7 years ago

This begins to address some of the concerns listed in #28. These are all formatting changes, nothing technical yet. From my tests everything seems to be working fine, but definitely look over this and test before merging, though, because a large part of it was automated.

When this does get merged, it will be a much more welcoming code base for new contributors.

homakov commented 7 years ago

What about switching to https://standardjs.com ?

andrewda commented 7 years ago

@homakov Sure, that sounds good!

homakov commented 7 years ago

Thanks, I won't be touching codebase then for a while.

andrewda commented 7 years ago

Alright - I'll try to get these done as quickly as possible.

andrewda commented 7 years ago

Not at home so haven't tested, but all the StandardJS issues should be fixed in main.js.

andrewda commented 7 years ago

Alright @homakov this should be good to go. Any other changes you want made?

menzow commented 7 years ago

Awesome job @andrewda. Thanks for implementing one of my suggestions. Btw: You might want to squash your commits before merging. This helps keeping the master branch clean.

git rebase -i HEAD~13

andrewda commented 7 years ago

Thanks @menzow! Will squash 'em now! 👍

andrewda commented 7 years ago

@menzow I squashed them into 4 different commits so it's easier to rollback an individual one if necessary.