search

sakusaku3939 / DeepLAndroid

Unofficial Android App for DeepL Translator
MIT License
353 stars 19 forks source link

hide cookie banner #2

Closed fm-sys closed 3 years ago

fm-sys commented 3 years ago

I saw in the code that there was a workaround to hide the cookie banner using cookieManager but it wasn't working (at least not at my device/geolocation) so I replaced that part with JavaScript.

Since it's probably best to keep the code all together at the same location, I created this pull request containing the fix...

fm-sys commented 3 years ago

I changed my language in the device settings to Japanese (hopefully I find the right button to change it back 😅) and now can reproduce the problem. Looks like the deepl website has different structures depending on the user language. So I will try to find a cross language solution...

sakusaku3939 commented 3 years ago

That makes sense... Thanks for doing the research. For now I'll merge this pull request for now. Thank you!