sakusaku3939 / DeepLAndroid

Unofficial Android App for DeepL Translator
MIT License
342 stars 19 forks source link

floating error about dark theme #34

Closed lascapi closed 2 years ago

lascapi commented 2 years ago

I got an error message floating everytime above the app.

Screenshot_20210824-135613

App version : 4.3 from f-droid Android version : 7.1.2

Thank's for this app :)

sakusaku3939 commented 2 years ago

Do you get this error message even if you don't start in dark mode?

S-H-Y-A commented 2 years ago

I think you need to update WebView and Chrome. Try to Update WebView and Chrome.

WebView google Play link Chrome google Play link

lascapi commented 2 years ago

I cannot start in dark mode because it's only since Android 10 ( https://developer.android.com/guide/topics/ui/look-and-feel/darktheme )

And everything is up to date. I use LineageOs 14.1 on a Nexus5

sakusaku3939 commented 2 years ago

Okay, thanks for the information. I think the error message is probably a mistake in my code. I'll fix it so that it only shows up when I run it in dark mode.👍

sakusaku3939 commented 2 years ago

@lascapi I tried it on a Nexus 5 with Android version 7.1.1 on an emulator, but could not reproduce it. In order to narrow down the cause of the problem, I would like you to check if the same phenomenon occurs in the previous version, v4.2. https://github.com/sakusaku3939/DeepLAndroid/releases/tag/v4.2

If you get the same error, it is likely that the default theme of LineageOs14.1 is set to dark mode.

lascapi commented 2 years ago

Hello, I tried with the 4.2 version and I got zero errors.

And I'm pretty sure LineageOs14 did't have the dark mode yet.

sakusaku3939 commented 2 years ago

Hmmm... Then could you please check again with v5.0, which was released 5 days ago? I'd like to find out if the error still shows up by pressing "dark mode" and "light mode" from the app shortcut that appears by holding down the app icon.

If you want to go further and solve the problem, we can create a dedicated apk for debugging to check the device specifications.

lascapi commented 2 years ago

Hi, it's ok now with the version 6.1 👍 Thank's