sakusaku3939 / DeepLAndroid

Unofficial Android App for DeepL Translator
MIT License
342 stars 19 forks source link

Add a button to switch languages #35

Closed Mephodio closed 2 years ago

Mephodio commented 2 years ago

For some reason, the button to switch input and output languages doesn't work in the application (but it does work on the website), so I tried to work around that. It's a dirty solution, but maybe you can do something with it.

screenshot

sakusaku3939 commented 2 years ago

Thanks for the pull request! Just before I do a review, where is the button to switch languages in the web version?

fm-sys commented 2 years ago

BTW, what about using the material swap icon instead of "S"?

https://fonts.google.com/icons?selected=Material%20Icons%3Aswap_vert%3A

grafik

Mephodio commented 2 years ago

Where is the button to switch languages in the web version?

I did some tests, and turned out that only desktop version has this button (even when opened on a small screen, which confused me):

screenshot

BTW, what about using the material swap icon instead of "S"?

Yep, my button looks ugly, and now i came up with another idea: instead of native button, add an html button from the desktop version. I'll try to implement this.

Mephodio commented 2 years ago

Now it looks better :)

screenshot

sakusaku3939 commented 2 years ago

It looks good.:+1: I did not want to add native buttons as much as possible. Thank you!