search

sakusaku3939 / DeepLAndroid

Unofficial Android App for DeepL Translator
MIT License
342 stars 19 forks source link

Add background to settings icon #55

Closed fm-sys closed 2 years ago

fm-sys commented 2 years ago

On my device, the settings icon is totally invisible. This could be solved by adding background to settings icon...

Screenshot_20211210_154750_com huawei android launcher

sakusaku3939 commented 2 years ago

Okay. I will deal with it in the near future. :eyes:

sakusaku3939 commented 2 years ago

This fix has been incorporated into v6.4! Please check if it works correctly: https://github.com/sakusaku3939/DeepLAndroid/releases/tag/v6.4

fm-sys commented 2 years ago

First of all, thanks for working on it!

However, I don't see a change with the new release. Looking at the code, you've replaced the SVG with a bitmap image, which however has a transparent background as well...

sakusaku3939 commented 2 years ago

Hmmm.... Just in case, it is possible that the cache is still there. Do you get the same result after reinstalling?

fm-sys commented 2 years ago

Do you get the same result after reinstalling?

Yes.

The PNG is transparent:

Screenshot_20211230_100636_org mozilla firefox_copy_410x354

sakusaku3939 commented 2 years ago

Oh, I'm sorry for my lousy work.🙄 Thanks for finding it! I'll fix it right away.

fm-sys commented 2 years ago

Don't worry, such things can happen to everyone... Thanks for working on it!

sakusaku3939 commented 2 years ago

Version v6.4 has been updated. Please check it out.

fm-sys commented 2 years ago

Works! Thanks for fixing it... 👍