search

sakusaku3939 / DeepLAndroid

Unofficial Android App for DeepL Translator
MIT License
342 stars 19 forks source link

Can't scroll through languages when launched in pop-up mode. #59

Closed sakusaku3939 closed 2 years ago

sakusaku3939 commented 2 years ago

From F-droid's support email.

Screenshot_1641353761

i1last commented 2 years ago

Seconded by. The same problem, and my language is very low on this list (Russian)

fm-sys commented 2 years ago

Indeed I can reproduce. Although I thought it was working in the emulator while implementing this feature...?!

sakusaku3939 commented 2 years ago

I changed the specification a bit, because scrolling up the language list overlaps with the action of closing the popup.:eyes:

From the next version, the popup will close only when you tap on a dark area.

fm-sys commented 2 years ago

From the next version, the popup will close only when you tap on a dark area.

Need to test it on a real device first, but is that really an acceptable solution?

fm-sys commented 2 years ago

Commit fe7fcc4 was ok as quick-fix, but it had introduced another glitch:

The popup should only collapse as soon as the webview has reached the upper scroll end. (Then we don't need the "will close only when you tap on a dark area"-workaround anymore as well)

Video