search

sakusaku3939 / DeepLAndroid

Unofficial Android App for DeepL Translator
MIT License
334 stars 18 forks source link

Create CI #63

Closed fm-sys closed 2 years ago

fm-sys commented 2 years ago

This workflow will automatically check all pull requests and and commits to master.

The check will fail, if the app is either unable to compile or it introduces lint errors (only errors, not for warnings, info...)

Furthermore it provides a debug apk which can be downloaded for testing purposes.

Built running Built passed Testing APK
Screenshot_20220107_204030 Screenshot_20220108_074728 Screenshot_20220108_074842
sakusaku3939 commented 2 years ago

Thank you so much for setting up the CI environment and addressing the 'MissingTranslation' lint error.

I have one last question. When I add a feature in the future, should I create a pull request myself?

fm-sys commented 2 years ago

I'm using the same CI script in one of my projects. Mostly I've continued to commit directly to master, and check if CI stays green.

Screenshot_20220109_105205

If the check really should fail, you can still make a second commit "fix CI". But most of the time, this should not happen anyway, because Android Studio will highlight lint errors with a red underscore.

But it's up to you :)

sakusaku3939 commented 2 years ago

I see. I'll try to push basic changes as before, and create pull requests for breaking changes, spec changes, etc. to get your opinions.

Thank you for answering!