sakusaku3939 / DeepLAndroid

Unofficial Android App for DeepL Translator
MIT License
334 stars 18 forks source link

Auto jumping to web browser instead of showing in app's webview #77

Closed voidregreso closed 2 years ago

voidregreso commented 2 years ago

As mentioned above, every time I open the app, the launch page automatically displays "Jump to external browser" after a few seconds instead of inside the app's internal webview. image

And after checking the logs, I find a persistent error: "Uncaught ReferenceError : $ is not defined". image

I hope this can be fixed.

sakusaku3939 commented 2 years ago

Thanks for reporting it! I was able to reproduce the problem on some devices and investigated in detail.

Regarding the "jump to external browser" issue.

Fixing shouldOverrideUrlLoading solved the problem. However, as described below, the code of the DeepL server has changed significantly, so the display is the same as when opened in a browser.

The fix for this problem worked on the old version of the DeepL server, so we have released it first as v7.3! https://github.com/sakusaku3939/DeepLAndroid/releases/tag/v7.3

Regarding the "$ is not defined" error.

It is likely that jQuery is not used in newer versions. Therefore, we are considering whether to rewrite all previous code in vanilla JS or dynamically load jQuery.

Regarding the issue of all class and id names being changed.

It turns out that when the DeepL server gets a new version, all the internal structure, class names, and id names are changed.

I usually use the developer mode of the browser when identifying the elements I want to hide. However, currently my browser does not yet reflect the new version, so it will take some time to fix the problem.

Finally, I am happy to report that an official Android version of the app is now available from DeepL! https://play.google.com/store/apps/details?id=com.deepl.mobiletranslator&referrer=utm_source%3Ddeepl%26utm_campaign%3DpageID400-m-first-cta%26anid%3Dadmob

(And since the only problem that was inconvenient for me has been solved, I am a little less motivated to develop)

sakusaku3939 commented 2 years ago

Thanks for your waiting! Partial, but fixed to hide unwanted elements and copy button works. https://github.com/sakusaku3939/DeepLAndroid/releases/tag/v7.4

The display of the language switch button and the adjustment of the visibility in dark mode will be fixed in the future.

Please report if it does not work properly.