Material You - Githubissues

Silther commented 2 years ago

I would like to have an material design theme in the app.

sal0max commented 2 years ago

Tell me what about the app isn't Material 3 ("You"), first.

Silther commented 2 years ago

The design is very appealing, but the colors are part of the material you theme.

You can see that the color theme of the currencies app doesn't fully match the color of the Google drive app. E.g. why are there green colored buttons?

Silther commented 2 years ago

Please don't get me wrong, I like the design very much, but there are still these little inconsistencies that don't fit in 100%.

sal0max commented 2 years ago

Okay, thanks a lot for the clarification.

There are so many aspects to Material 3, and so many possibilities. Hence it's hard to understand what one means with such a generic request like "I would like to have an material design theme in the app". Especially when there was already a discussion and I have already implemented the Material 3 base theme.

So, I take you propose to change the fixed primary color to a dynamic color on devices with API ≥ 31. This would make everything that's green right now dynamic: arithmetic buttons, floating action buttons, settings headings, etc. That's definitely something I would consider.

This would be the result:

dynamic-primary

Also, while at it, I could add support for a monochrome launcher icon:

monochrome-launcher-icon

Is that what you had in mind?

Silther commented 2 years ago

That looks wonderful And maybe add an option to match the colour of the delete button, or just of all the red elements.

Silther commented 2 years ago

I have another question, is the background colour behind the green button part of Material 3? I have hardly seen it in any other app. Normally, such surfaces tend to have darker colours.

sal0max commented 2 years ago

Light mode: https://github.com/sal0max/currencies/blob/master/app/src/main/res/values-v31/colors.xml#L5 Dark mode: https://github.com/sal0max/currencies/blob/master/app/src/main/res/values-night-v31/colors.xml#L5

So, it's lighter than the background in dark mode and darker than the background in light mode. Also, it's dynamic.

Silther commented 2 years ago

Comparison GApps/Currencies:

Could that also be changed? So that it looks like the GApps.

Silther commented 2 years ago

If not everybody wants it, you could add an option like the oled black one.

sal0max commented 2 years ago

Alright, thanks for the additional feedback.

My two cents:

Not every app should be a clone of one "benchmark" app, if there exists even such a thing. Especially because the GApps themselves often disobey design guidelines (take e.g. Maps). Also, check out the Google Calculator app with M3 design. There, the display is brighter than the number pad in dark mode and darker in light mode. Additionally, buttons are not all the same color tone, but have different shades, depending on function and importance.
It is definitely not the right way, to clutter an app in making an option for every little detail, especially when it is only the look. Might be something an enthusiast wishes, but that is absolutely counterproductive for the average user.

I will try out different kinds of background shades and how a dynamically colored delete button will look, but there will be no options for it.

Silther commented 2 years ago

Perfect, I don't want all apps to look exactly the same, but I think the GApps Material You has been implemented very well. It would definitely be nice if the colour theme also applied in surfaces.

sal0max commented 2 years ago

As written: The surface colors already are dynamic. Check out the docs. There is a ton of different dynamic colors. The apps from your screenshots just chose to pick more flashy tones.

There are plenty of people which don't like that apps all look completely tinted with some striking color. I'm one of them. It makes them less distinguishable. Just read the reviews of the Google Calculator app. That's why I don't want to go full paint bucket mode.

I like constructive feedback. But to be honest, it's a bit annoying you just wanting me to 100% imitate other apps when you seemingly didn't even understand that Material 3 isn't "do it exactly this way and no way else". This isn't Holo any more.

Silther commented 2 years ago

I just wanted to avoid any misunderstandings as English is not my mother tongue.

sal0max commented 2 years ago

Dynamic colored buttons added in 920962b02583dd88edba6560e0f4640b88341f4b. As already stated: Background colors already are fully dynamic.

Will arrive with the next update in the app stores.

sal0max / currencies

Material You #32