sal0max / currencies

An exchange rates currency converter for Android
GNU General Public License v3.0
238 stars 22 forks source link

Feature : An Extra user configurable currency #4

Closed S-360 closed 3 years ago

S-360 commented 3 years ago

Add an EXTRA currency which is linked to the Dollar or Euro that the user can set a custom exchange rate for.

If the desired currency isn't available you can simple use the EXTRA currency.

sal0max commented 3 years ago

I know of some currencies linked to the USD. Mostly middle eastern money. Like the Bahraini dinar (1 USD = 0,376 BHD), the Saudi riyal (1 USD = 3,75 SAR), United Arab Emirates dirham (1 USD = 3.6725 AED) and so on…

Are those the use case for your proposed feature? Because maybe it's better to just hard code those into the app. Could indeed be useful. UAE seems a popular vacation location, in these times…

If not, what is your use case?

S-360 commented 3 years ago

Not exactly....guess I'm not that great at explaining what I mean, I'll try again.

There is actually another currency app on Fdroid which has this feature.

They have created and extra currency called EXT which by default is 1=1 to the Euro. There is a menu option for the user to change/set this rate.

For exaple the user can Set EXT=2.45 now 1EUR=2.45EXT

You can then pair the EXT currency with any other, works really well.

This would save you from having to add ever single currency to the app. The user could simply use the EXT currency and set a rate to whatever they want against the euro. (Not sure why the other app chose euro as default seeing as the USD is the world reserve currency)

Additionally maybe allow the user to create Multiple EXT currencies and also allow custom names?

So for example users could set/change EXT1 = UAE EXT2 = PKR EXT3 = BTC and so on

Also perhaps the ability to show more than one currency to the user at a time?

I prefer your app, UI is much nicer and the calculator feature is great!

Here is a link, perhaps you could check it out.

https://f-droid.org/repo/org.billthefarmer.currency

https://github.com/billthefarmer/currency

sal0max commented 3 years ago

Okay, I get your idea: Add additional currencies, with a custom rate relative to another selectable currency.

Still, if you don't count small countries like Kiribati and if you neglect currencies with a rate of 1:1, there are only a handful of currencies which are linked to EUR/USD/…: https://en.wikipedia.org/wiki/List_of_circulating_fixed_exchange_rate_currencies

Wouldn't it be much user friendlier to hard code those few? I'm thinking of e.g. AED, BHD, QAR, SAR, and maybe some others. I'd imagine a typical user, going on vacation in Dubai, rather wants to just select the dirham instead of informing himself about the exchange rate and having to program it.

Regarding your example with PKR and BTC: In my opinion it doesn't really make sense, as those two currencies aren't pegged to another currency, so you'd have to constantly keeping them updated.

S-360 commented 3 years ago

Interesting, thanks for that link. Guess it would be easier to hard code seeing as those currencies are pegged to USD

Still, would be nice option to have that extra currency for those that would like to customise.

sal0max commented 3 years ago

I've thought about it and came to following conclusion: