[Feature Request] Open Exchange Rates data provider

sal0max / currencies

An exchange rates currency converter for Android

GNU General Public License v3.0

227 stars 23 forks source link

[Feature Request] Open Exchange Rates data provider #53

Closed lord-aerion closed 8 months ago

lord-aerion commented 8 months ago

With the loss of exchangerate.host the number of currencies supported by this amazing app has dropped considerably.

Would you consider adding support for Open Exchange Rates? They offer a forever free plan that's limited to two API keys and 1,000 API calls a month, more than adequate for the target audience of this app, i.e., casual travellers.

I appreciate this is more of an advanced feature since not everyone knows what an API is, but it's not exactly rocket science either. It is supported by at least two other apps on F-Droid: My Expenses and STARGW FX, and both provide very basic instructions on what to do (essentially register a free account on openexchangerates.org and provide your API key/App ID here).

It would greatly increase the amount of supported currencies (over 200), with the benefit of hourly updates.

sal0max commented 8 months ago

I tried to implement support for Open Exchange Rates. However, they heavily limit the usage of their time series API:

Time Series requests are currently available for clients on the Enterprise and Unlimited plans.
The maximum query period currently allowed is one month. If you need more than one month’s data, please request months sequentially
Please note that each day requested counts as one API request (so requesting a full month of data will count as up to 31 ‘hits’).

This will make it impossible to provide time series in this app. Do you have any suggestion how to remedy this situation?

lord-aerion commented 8 months ago

I'm afraid not. I just created a free account, and added the App ID (their term for API key) to the aforementioned apps. The free account states that it provides hourly updates and 1000 API calls a month.

That suggests that Time Series is something other than hourly updates.

sal0max commented 8 months ago

Yeah, the amount of API calls used for time series is one issue. But not being available to free users simply breaks it.

However I'm thinking about providing this API for regular usage anyway and simply showing a message that this API doesn't support time series. I guess it's a feature not heavily used.

The benefit of that wide range of exchange rates might be worth it.

sal0max commented 8 months ago

I've implemented this API. No support for timeline data, though. Users have to enter their own API Key.

Will arrive with the next release.

e0207d36e78c218c64dc0eb539d1427d5200de36

sal0max commented 8 months ago

v1.22.0 releases, which contains this feature.