sal0max / currencies

An exchange rates currency converter for Android
GNU General Public License v3.0
231 stars 22 forks source link

MathParser.org-mXparser v5.0 and later is not FOSS #55

Closed licaon-kter closed 9 months ago

licaon-kter commented 9 months ago

ref: https://github.com/mariuszgromada/MathParser.org-mXparser/blob/v.5.0.0/LICENSE.txt

ref: https://github.com/mariuszgromada/MathParser.org-mXparser/issues/314

ref: https://github.com/sal0max/currencies/blob/1.16.0/app/build.gradle#L95

/LE: disabled affected versions https://gitlab.com/fdroid/fdroiddata/-/commit/93f7c460c3f372fed1be92532e76c0214f8140d4

sal0max commented 9 months ago

So, according to the discussion on the same topic @ https://github.com/Yet-Zio/yetCalc/issues/98, there's nothing I can do about the F-Droid removal, other than searching for a different library, or implementing the functionality myself, right?

That's really unfortunate for the F-Droid users.

Do you maybe have some help to solve this issue? Like an alternative library?

sal0max commented 9 months ago

Follow-up question: Would it suffice, if I'd downgrade the lib to 4.4.x? License: https://github.com/mariuszgromada/MathParser.org-mXparser/blob/v.4.4.2/LICENSE.txt

I guess I don't need all those fancy v5 features. Only basic arithmetics are used in my app. This should be covered by v4.

Ping @mariuszgromada - Or do you recommend not using v4 any more, for some reason?

licaon-kter commented 9 months ago

From a licensing point of view latest v4 looks ok.

mariuszgromada commented 9 months ago

v.4.4.2 license was w BSD one, but please note that it contains multiple bugs identified later and fixed in v.5x.

I would like to help you somehow, but I don't know how to do it so that you can use the non-commercial license. This is some strange approach of F-Droid that they remove applications that contain use of my software according to the license...

licaon-kter commented 9 months ago

It's not strange, the F-Droid Main repo contains only software that is FOSS, built from FOSS licensed code.

It's a simple rule, imho.

But you are free to license your lib as you see fit, nothing wrong with that.

sal0max commented 9 months ago

I thank everyone for your statements. Especially @mariuszgromada !

I guess for now I could wager that v4 is stable and sufficient for my app with only basic mathematic functionality. Nevertheless, a pity for other apps getting removed from F-Droid.

mariuszgromada commented 9 months ago

@licaon-kter I understand that, but in this way they limit the choice of software developers use. By introducing a commercial license, I wanted to leave the option of non-commercial use and I allow it. Additionally, the creator cannot purchase licensed software and use it in the apps published in F-Droid - strange. Conclusion - F-Droid is probably making money from your software.

licaon-kter commented 9 months ago

@mariuszgromada

but in this way they limit the choice of software developers use Additionally, the creator cannot purchase licensed software and use it in the apps published in F-Droid

No, they can use whatever... they can't be in F-Droid though.

The list of FOSS licenses accepted is here: https://spdx.org/licenses/ (only those with Y on the FSF and/or OSI columns)

Conclusion - F-Droid is probably making money from your software.

That would not be prohibited by any FOSS license, that would be within F-Droids (or anyone's, yes even your) rights, yes.

You can buy all the FOSS software from https://f-droid.org, SPECIAL SALE JUST THIS WEEK ALL APPS FOR $0!!!!!1111

opk12 commented 8 months ago

@mariuszgromada

Conclusion - F-Droid is probably making money from your software.

F-droid is this folder of peer-shared build scripts + volunteer-run servers.

By introducing a commercial license, I wanted to leave the option of non-commercial use and I allow it.

I hope I can reiterate from your issue, that copyright does not work as assumed in the license, and that there is a standard GPL + commercial dual-licensing solution.

sal0max commented 8 months ago

ping @licaon-kter

The latest release (1.22.0) uses v4 of mXparser lib: https://github.com/sal0max/currencies/blob/1.22.0/app/build.gradle.kts#L114

Do I have to do something, or do you take care of the F-Droid repo listing?

licaon-kter commented 8 months ago

Will take a look asap