search

sal0max / grav-plugin-shortcode-gallery-plusplus

A Shortcode extension to add sweet galleries with a lightbox to your Grav website.
MIT License
33 stars 8 forks source link

Optimize page loading #14

Closed stasicki closed 2 years ago

stasicki commented 3 years ago

resolves sal0max/grav-plugin-shortcode-gallery-plusplus#12

sal0max commented 3 years ago

Thanks for your contribution! I like your idea.

However I couldn't quite make it work. If changing this: ![Alt 1](photo-1494438639946-1ebd1d20bf85.jpg 'Title 1') to this: ![Alt 1](photo-1494438639946-1ebd1d20bf85.jpg?link 'Title 1') the dump shows, that no link is generated. Only the thumbnail image is used, but it isn't wrapped in a <a href> with the link to the large image.

Before: ^ "<img title="Title 1" alt="Alt 1" src="/user/pages/demo/02.gallery-plusplus/photo-1494438639946-1ebd1d20bf85.jpg" />"

After: ^ "<img title="Title 1" alt="Alt 1" src="/user/pages/demo/02.gallery-plusplus/photo-1494438639946-1ebd1d20bf85.jpg.thumb.jpg" />"

This results in the thumbnail image being used as preview and as large image.

sal0max commented 2 years ago

This is solved in a more sophisticated way in PR https://github.com/sal0max/grav-plugin-shortcode-gallery-plusplus/pull/16 So I'm closing this one.

Anyway, thanks a lot for your work