sal0max / grav-plugin-shortcode-gallery-plusplus

A Shortcode extension to add sweet galleries with a lightbox to your Grav website.
MIT License
33 stars 8 forks source link

Stop disabling cache, use "shortcode->addAssets()" #17

Closed ghost closed 3 years ago

ghost commented 3 years ago

Hello ! Disabling cache can lead to a lot of problems, and we can use shortcode->addAssets() to avoid disabling it. Tested with Grav 1.7.20 without "AdvancedPageCache" plugin (And also tested with). Have a nice day ! ^^

sal0max commented 3 years ago

Great work! Thanks so much!

ghost commented 3 years ago

You're welcome, I'm glad I could help. The only problem with my solution is that the inline <script> can't be at the end of the <body>. This is not a real problem, but it would have been better. Have a nice day ! ^^