search

sal0max / grav-plugin-shortcode-gallery-plusplus

A Shortcode extension to add sweet galleries with a lightbox to your Grav website.
MIT License
33 stars 8 forks source link

Going to top of website when opening gallery on mobile device #19

Closed bartoszwanot closed 2 years ago

bartoszwanot commented 2 years ago

Hi! I've fund a bug that can be annoying for people reading articles on mobile devices (smartphone).

When you open the gallery with images, the whole website is scrolling back to the top in the background, so when the user is closing the gallery he needs to scroll down to the place when he was reading. Tested on Samsung Galaxy S10e device with latest Chrome and Samsung's stock web browser, but you can see the same behavior on Chrome or Edge when emulating mobile device in DevTools.

You can check such behavior here on my website: https://nindyki.pl/instax-mini-link-recenzja (which runs on Grav v1.7.20).

sal0max commented 2 years ago

I can't reproduce that behavior in my sites. Here's another user of this plugin: https://eduardomataicasa.com/en/artworks The issue you mention doesn't happend there, either.

bartoszwanot commented 2 years ago

Yeah, on that website it works without problem. But on my site something is wrong... Any idea what can be the cause?

bartoszwanot commented 2 years ago

Okay, thanks to my friend I've found the cause of such behavior - it was fault of CSS for sticky-footer class, where height was set to 100%. By removing it there is no problem with it. I'm closing this issue in such case.

sal0max commented 2 years ago

Thanks for the update! Can be helpful to others.

Cheers!