sal0max / grav-plugin-shortcode-gallery-plusplus

A Shortcode extension to add sweet galleries with a lightbox to your Grav website.
MIT License
33 stars 8 forks source link

"justified-gallery" disappeard after recent update of Shortcode Gallery++ v1.2.1 #22

Closed tangr04 closed 3 years ago

tangr04 commented 3 years ago

Hello!

After the recent update of Shortcode Gallery++ (v1.2.1) my images are not arranged as justified gallery anymore.

I have updated the plugin on a test-website first and it shows a different arrangement of my images, than on the website which is online. After opening the inspector and comparing both portfolios, it shows that the class="justified-gallery" is not there anymore on the test-site.

this is the website where it works correctly (I haven´t updated the plugin here): https://www.lexart-tattoo.at/

How can I fix this on my test site?

Thanks a lot in advance.

Shortcode-Gallery-after-update Shortcode-Gallery-before-update

sal0max commented 3 years ago

Usually, such problems are caused by other plugins or themes.

Could you try setting the default theme and disabling other plugins one by one to isolate the problem?

tangr04 commented 3 years ago

Hello! Thanks for your quick response.

I switched to the default theme (Quark) and the updated plugins works fine – the “justified-gallery”-setting didn´t disappear there.

I am using a child theme of Ceevee, so I activated the Ceevee theme, but it´s not working there – how can I make it work?

Von: sal0max @.> Gesendet: Mittwoch, 27. Oktober 2021 14:44 An: sal0max/grav-plugin-shortcode-gallery-plusplus @.> Cc: Gruber Tanja @.>; Author @.> Betreff: Re: [sal0max/grav-plugin-shortcode-gallery-plusplus] "justified-gallery" disappeard after recent update of Shortcode Gallery++ v1.2.1 (Issue #22)

Usually, such problems are caused by other plugins or themes.

Could you try setting the default theme and disabling other plugins one by one to isolate the problem?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/sal0max/grav-plugin-shortcode-gallery-plusplus/issues/22#issuecomment-952887517, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AWFMYEES7SFCKRVRZ4PFILLUI76YPANCNFSM5G2FKJ4Q. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

sal0max commented 3 years ago

Great work isolating the problem. Indeed, Ceevee is at fault, here. Nothing I can do with this plugin to remedy the issue.

However, I made a pull request for Ceevee, to fix the issue: https://github.com/getgrav/grav-theme-ceevee/pull/16

Once Ceevee is updated (and maybe the child theme you're using), this should be fixed. In the meantime, you can check out my pull request. It's a simple fix, which you can copy to your local version of the theme.

tangr04 commented 3 years ago

Thanks for the fix! It´s looking good again.

Von: sal0max @.> Gesendet: Donnerstag, 28. Oktober 2021 13:35 An: sal0max/grav-plugin-shortcode-gallery-plusplus @.> Cc: Gruber Tanja @.>; Author @.> Betreff: Re: [sal0max/grav-plugin-shortcode-gallery-plusplus] "justified-gallery" disappeard after recent update of Shortcode Gallery++ v1.2.1 (Issue #22)

Great work isolating the problem. Indeed, Ceevee is at fault, here. Nothing I can do with this plugin to remedy the issue.

However, I made a pull request for Ceevee, to fix the issue: getgrav/grav-theme-ceevee#16https://github.com/getgrav/grav-theme-ceevee/pull/16

Once Ceevee is updated (and maybe the child theme you're using), this should be fixed. In the meantime, you can check out my pull request. It's a simple fix, which you can copy to your local version of the theme.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/sal0max/grav-plugin-shortcode-gallery-plusplus/issues/22#issuecomment-953760400, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AWFMYEDIFCWFGQAHWQ53AYTUJE7QVANCNFSM5G2FKJ4Q. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

beamaria commented 2 years ago

@sal0max Hi I have the same problem with Helium: the class="justified-gallery" is not there anymore.

My settings: Shortcode gallery+++ v 1.2.1 Helium v 5.5.11 Gantry 5 v 5.5.11 Grav v.1.7.30 Admin Panel v. 1.10.30.2

I tried to locate the base.html.twig file of the theme, but i couldn't find it

Any idea how to fix the issue?