search

sal0max / grav-plugin-shortcode-gallery-plusplus

A Shortcode extension to add sweet galleries with a lightbox to your Grav website.
MIT License
33 stars 8 forks source link

Gantry 5 Adding Shortcode in Custom HTML Particle Fails #29

Closed EthicalObligation closed 1 year ago

EthicalObligation commented 2 years ago

image image

sal0max commented 1 year ago

Gantry is a project I'm not familiar with, and a project I don't plan on getting familiar with anytime soon.

As the problem seems to only appear there and not when this plugin is regularly used, I'd say this is something Gantry has to fix. As long as you can't point out what could cause the problem that is this plugins responsibility, I won't look into this.

ghost commented 1 year ago

Hello, I think it's because the Gantry plugin doesn't trigger event the same way Grav does for a normal display of the page. The solution would be to check if $currentPage isn't null before using. I can do a PR if you wish, that was my code. ^^ In the meantime, have a nice day/evening !

EthicalObligation commented 1 year ago

Hello, I think it's because the Gantry plugin doesn't trigger event the same way Grav does for a normal display of the page. The solution would be to check if $currentPage isn't null before using. I can do a PR if you wish, that was my code. ^^ In the meantime, have a nice day/evening !

That would be greatly appreciated!

ghost commented 1 year ago

(I'm sorry for the wait time, but I'm waiting for @sal0max to answer to my PR #32)