search

sal0max / grav-plugin-shortcode-gallery-plusplus

A Shortcode extension to add sweet galleries with a lightbox to your Grav website.
MIT License
33 stars 8 forks source link

Readme.md has incorrect example code. #5

Closed ncadigan closed 3 years ago

ncadigan commented 3 years ago

[gallery rowHeight=230 margins=25 lastRow="justify" captions="false" border=0] ![Alt text 1](image.jpg) ![Alt text 2](/images/image.jpg) ![relative link](../image.jpg) ![remote link](https://remotesite.com/image.jpg) ... [/gallery] Above code does not work. It displays as plain text.

Keeping it as one line does work though. [gallery rowHeight=230 margins=25 lastRow="justify" captions="false" border=0] ![Alt text 1](image.jpg) ![Alt text 2](/images/image.jpg) ![relative link](../image.jpg) ![remote link](https://remotesite.com/image.jpg) ... [/gallery]

sal0max commented 3 years ago

Thanks for the report.

I tested my example again, and it works. However, trying different configurations, I found a way that breaks it. What's your setting in /user/config/system.yaml for the key pages|markdown|auto_line_breaks? true breaks the page, false renders properly. false is also the default value.

So, this is basically an issue only in some user configurations.

But to not confuse anyone, I will probably change the example.

Cheers!

sal0max commented 3 years ago

Changed in 4480352bd6a13f83f540ef37e9e3b93392f3765a

ncadigan commented 3 years ago

Correct, I have auto_line_breaks set to true.