search

sal0max / grav-plugin-shortcode-gallery-plusplus

A Shortcode extension to add sweet galleries with a lightbox to your Grav website.
MIT License
33 stars 8 forks source link

Is there an known incompalibility with other plugins #6

Closed awrog closed 3 years ago

awrog commented 3 years ago

I love your gallery-plugin. Installed on my GRAV v1.6.25 site. The images are displayed fine, but the navigation does not seem to work. I've also got UniteGallery and Featherlight plugin active. Disabling them does not solve the problem. Enabling and disabling the page cache does not make any difference. I hope you can shed some light on the matter.

sal0max commented 3 years ago

The reason is your user/themes/quark-open-publishing/js/my.js script. When I block it, the lightbox works as intended.

If I'm not mistaken, this script catches clicks on all links without the class external-link, gets the link url and opens it in a blank window. Maybe you can extend the a:not(.external-link):not([href^="#"]) block with something like a:not([class^="glightbox"]). (I'm no javascript expert)

I'd love to hear if that solves your problem. Anyway, I don't think there's anything I can do with my plugin.

Cheers!

awrog commented 3 years ago

sal0max,

Great! I already have a plugin for that (opening a link in a blank window/tab, https://github.com/hibbitts-design/grav-plugin-external-links) So I've disabled /quark-open-publishing/js/my.js (it works great now!)

Thanks for having a look at it!

Arno Rog

On Sat, Feb 13, 2021 at 5:52 PM sal0max notifications@github.com wrote:

The reason is your user/themes/quark-open-publishing/js/my.js script. When I block it, the lightbox works as intended.

If I'm not mistaken, this script catches clicks on all links without the class external-link, gets the link url and opens it in a blank window. Maybe you can extend the a:not(.external-link):not([href^="#"]) block with something like a:not([class^="glightbox"]). (I'm no javascript expert)

I'd love to hear if that solves your problem. Anyway, I don't think there's anything I can do with my plugin.

Cheers!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sal0max/grav-plugin-shortcode-gallery-plusplus/issues/6#issuecomment-778644446, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC4XGQ5ATDBOW2GGYNU3JOTS62U3XANCNFSM4XSGL65Q .

-- Met vriendelijke groet,

Arno Rog

paulhibbitts commented 3 years ago

Glad you found a workaround @awrog! That was a suggestion I was going to make🙂 BTW, that JS code is only needed if you use the chromless feature in QOP for embedding Grav pages into other systems etc.