Closed vecjh closed 3 years ago
Thanks for the info. I took a look at this behavior and found the following:
Without the image-captions plugin intervening, a Markdown image link like ![](image.jpg)
gets converted to e.g.
<img alt="" src="/user/pages/demo/image.jpg" />
With the image-captions plugin the Markdown ![](image.jpg?classes=caption "Caption")
gets converted to:
<figure class="image-caption">
<img title="Caption" alt="" class="caption" src="/user/pages/demo/image.jpg">
<figcaption class="">My Image Caption</figcaption>
</figure>
Besides the figure
-stuff, there's a major difference:
img
element without closing tag./>
.The Regex my plugin includes, expected the closing Tag to be there.
So, tldr;: That's a quick fix I can do. Thanks for this issue. Update is on its way.
Fixed in 6cfda86341ffd0da663168b854581cd9534f9416
wow, thanks a lot for prompt feedback! I confirm it works now.
Hello, I have your plugin with default configuraiton. When I have "trilbymedia/grav-plugin-image-captions" plugin enabled and reference an image with 'caption' class in my page, i.e.
![](image1.jpg?classes=caption,center "My image caption")
Then any [gallery] within the same page is not rendered anymore.
The source section becomes just empty:
While it still works if the same image comes only with the 'center' class selector.
![](image1.jpg?classes=center "My image caption")
Just in case - I use "quark-open-publishing" theme