sal0max / muzei-nationalgeographic

The National Geographic photo of the day for Muzei.
GNU General Public License v3.0
39 stars 7 forks source link

Android 12: Crash after latest update #14

Closed bashtian closed 2 years ago

bashtian commented 2 years ago

Following Android 12 change leads to a crash in the current version of the plugin: https://developer.android.com/about/versions/12/behavior-changes-12#pending-intent-mutability

AndroidRuntime: java.lang.IllegalArgumentException: de.msal.muzei.nationalgeographic: Targeting S+ (version 31 and above) requires that one of FLAG_IMMUTABLE or FLAG_MUTABLE be specified when creating a PendingIntent.
AndroidRuntime: Strongly consider using FLAG_IMMUTABLE, only use FLAG_MUTABLE if some functionality depends on the PendingIntent being mutable, e.g. if it needs to be used with inline replies or bubbles.
sal0max commented 2 years ago

Thanks a lot for the issue. Can confirm. Caused by an old non-androidx library.

sal0max commented 2 years ago

Fixed in 95f87df1c2aee6e8016fa89cd1a676a39de1a8fc

sal0max commented 2 years ago

Update is now live in the Google Play Store.

bashtian commented 2 years ago

Works again, thank you for the quick fix!