salad / salad

A nice mix of great BDD ingredients
BSD 3-Clause "New" or "Revised" License
121 stars 25 forks source link

Random defects #26

Open medwards opened 12 years ago

medwards commented 12 years ago

Will update this as I pair with someone using Salad, and then we can tear it up into individual bugs to work on:

skoczen commented 11 years ago

Ideally, if these can become separate issues, that'd be fantastic. For now:

The subject 'button' doesn't seem to use 'with the value' properly (although in the code it says "this doesn't make sense" lol)

Yep, I think that's a "the mapping doesn't quite fit" issue. Unless there's a proposal, calling NAB.

The subject selector 'with the css' doesn't accept more than one class and has a > at the end of the documentation
Links containing HTML don't seem to work with the partial selector (id <a><table><tr><td>some text I might want for a partial selector</td></tr></table></a>)
Are id's not supported for links?

This should work. For example things like , a#myID I'm sure are working in one of my codebase or another. Can you open an issue with specific fail cases?

css selector could alternatively be class? or class selector? Ah ignore css selector remakrs, this makes sense now.  

CSS selector == sizzle selector. So .foo.bar, span:last #fooBar, etc.

A simpler lookup by class option would be nice too

This should just be .className. Are you seeing something else? Or is this a proposal for the sugar "with the class 'foo'"?

label with the value "x" doesn't seem to work (value is <label>thisisthevalue</label> right?)

Nope. Labels don't have values.

Can we search for labels by their 'for' attribute?

Not sure off the top of my head, going to depend on sizzle/splinter support. If so, it's

element with the css selector "label[foo=bar]"

I can't focus the link with the text "blah" and I'm assuming many other actions don't work as well

Focusing is wonky in FF. Feel free to open a ticket for this!