saladenicoise / SOEN-487-Galactus

Final Project for SOEN 487
4 stars 1 forks source link

Authentication #59

Closed jaskaran-dhadda closed 1 year ago

jaskaran-dhadda commented 1 year ago

Added Bootstrap 5 + Icons for styling Added registration and login via Firebase Authentication * Added profile and preferences pages with Firebase's Realtime Database Added vuex for state management Segmented code into components for readability Added Cypress tests for the sign in page Added additional styling Refactored certain elements a bit

cipher-chief* repository was dropped in favor of built-in auth features for easier deployment

gitguardian[bot] commented 1 year ago

⚠️ GitGuardian has uncovered 12 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [6176111](https://dashboard.gitguardian.com/incidents/6176111?occurrence=89318745) | Google API Key | e0e65d79ce76f6bdfbdf8cb24e2dcae2e7e315f5 | cipher-chief/auth/actions.js | [View secret](https://github.com/saladenicoise/SOEN-487-Galactus/commit/e0e65d79ce76f6bdfbdf8cb24e2dcae2e7e315f5#diff-c8ae703e2c1a75a7c8223f0cd19e6f323950d66742048bd1087a94477e63b4b2R4) | | [6176111](https://dashboard.gitguardian.com/incidents/6176111?occurrence=89318746) | Google API Key | e0e65d79ce76f6bdfbdf8cb24e2dcae2e7e315f5 | cipher-chief/auth/actions.js | [View secret](https://github.com/saladenicoise/SOEN-487-Galactus/commit/e0e65d79ce76f6bdfbdf8cb24e2dcae2e7e315f5#diff-c8ae703e2c1a75a7c8223f0cd19e6f323950d66742048bd1087a94477e63b4b2R34) | | [6171532](https://dashboard.gitguardian.com/incidents/6171532?occurrence=89630849) | AMQP Credentials | e10a696d155375635ec96c0a8c3c222c36279600 | data-demon/rabbitmq-utility/rabbit.js | [View secret](https://github.com/saladenicoise/SOEN-487-Galactus/commit/e10a696d155375635ec96c0a8c3c222c36279600#diff-dcb2c5fdb47b6e118c242e8af842b130e0e2b132e849a2da5742de3bc11be6d1R3) | | [6171532](https://dashboard.gitguardian.com/incidents/6171532?occurrence=89630851) | AMQP Credentials | e10a696d155375635ec96c0a8c3c222c36279600 | notify-nexus/producer.js | [View secret](https://github.com/saladenicoise/SOEN-487-Galactus/commit/e10a696d155375635ec96c0a8c3c222c36279600#diff-8e9c0c6ad6dc1f78301f7ec740fa850fbee448eb1d688f8f6cf7f5e7cb7ea815R3) | | [6171532](https://dashboard.gitguardian.com/incidents/6171532?occurrence=89630854) | AMQP Credentials | e10a696d155375635ec96c0a8c3c222c36279600 | notify-nexus/consumer.js | [View secret](https://github.com/saladenicoise/SOEN-487-Galactus/commit/e10a696d155375635ec96c0a8c3c222c36279600#diff-9b103a33244bff2b6ceccb8bc935fd1e5aeafc84329ed9b2ac166088ac88c34aR3) | | [6174712](https://dashboard.gitguardian.com/incidents/6174712?occurrence=89630852) | Generic High Entropy Secret | e10a696d155375635ec96c0a8c3c222c36279600 | data-demon/weather-utility/geoCodingAPI.js | [View secret](https://github.com/saladenicoise/SOEN-487-Galactus/commit/e10a696d155375635ec96c0a8c3c222c36279600#diff-f32597951e87944ec44eb4f58d1b38225d5d86cd85b25d6e0586d51b3058e721R1) | | [6174713](https://dashboard.gitguardian.com/incidents/6174713?occurrence=89630848) | Generic High Entropy Secret | e10a696d155375635ec96c0a8c3c222c36279600 | data-demon/weather-utility/geoCodingAPI.js | [View secret](https://github.com/saladenicoise/SOEN-487-Galactus/commit/e10a696d155375635ec96c0a8c3c222c36279600#diff-f32597951e87944ec44eb4f58d1b38225d5d86cd85b25d6e0586d51b3058e721R2) | | [6174714](https://dashboard.gitguardian.com/incidents/6174714?occurrence=89630850) | Generic High Entropy Secret | e10a696d155375635ec96c0a8c3c222c36279600 | data-demon/weather-utility/weatherRetrievalAPIs.js | [View secret](https://github.com/saladenicoise/SOEN-487-Galactus/commit/e10a696d155375635ec96c0a8c3c222c36279600#diff-5301580bf1c85f97f117b939161b919273d2241fd7fd55d400c150b6f4cd2c08R4) | | [6174715](https://dashboard.gitguardian.com/incidents/6174715?occurrence=89630853) | OpenWeatherMap Token | e10a696d155375635ec96c0a8c3c222c36279600 | data-demon/weather-utility/weatherRetrievalAPIs.js | [View secret](https://github.com/saladenicoise/SOEN-487-Galactus/commit/e10a696d155375635ec96c0a8c3c222c36279600#diff-5301580bf1c85f97f117b939161b919273d2241fd7fd55d400c150b6f4cd2c08R3) | | [6186110](https://dashboard.gitguardian.com/incidents/6186110?occurrence=89630846) | Bearer Token | e10a696d155375635ec96c0a8c3c222c36279600 | notify-nexus/scheduler/jobs/alert_template.sh | [View secret](https://github.com/saladenicoise/SOEN-487-Galactus/commit/e10a696d155375635ec96c0a8c3c222c36279600#diff-962c2924c3ea0bc01ea86f7cce1d214c6b63115d46b8b6228eb3c1a9b365eb7dR8) | | [6186110](https://dashboard.gitguardian.com/incidents/6186110?occurrence=89630855) | Bearer Token | e10a696d155375635ec96c0a8c3c222c36279600 | notify-nexus/scheduler/jobs/alert_scheduler.sh | [View secret](https://github.com/saladenicoise/SOEN-487-Galactus/commit/e10a696d155375635ec96c0a8c3c222c36279600#diff-03ce87e337f023ec776a01690dc0da8e0fc54e38ee8aaf6e414f824e646ac372R3) | | [6186111](https://dashboard.gitguardian.com/incidents/6186111?occurrence=89630847) | Generic High Entropy Secret | e10a696d155375635ec96c0a8c3c222c36279600 | notify-nexus/testing_notification.js | [View secret](https://github.com/saladenicoise/SOEN-487-Galactus/commit/e10a696d155375635ec96c0a8c3c222c36279600#diff-a1422e16841c82500e2fee4be58559b3143c7b30bcec47a1e317930955c47f6fR5) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/specifics/googleaiza#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

eyeshield2110 commented 1 year ago

Since there's merge conflict due to my changes in the sky-siren module, I'll add myself as reviewer

kkodmani commented 1 year ago

Things look good but only 3/4 cypress tests pass. Your sign out button is missing Screenshot 2023-04-03 092341

eyeshield2110 commented 1 year ago

@jaskaran-dhadda @EliasSabbagh47 @Quoiquecesoit Hey team, just letting you know: Please prioritize reviewing PRs over adding commits to a branch

As this PR is huge, it needs to be merged asap

Steps to do before approving this PR: