saladenicoise / SOEN-487-Galactus

Final Project for SOEN 487
4 stars 1 forks source link

Issue#4 communication data service notification service backup #65

Closed eyeshield2110 closed 1 year ago

eyeshield2110 commented 1 year ago

Alert microservice

This is a microservice that polls the weather retrieval service for alerts our users are subscribed to. Ex. If Im subscribed to alerts in montreal, my device will now receive weather alert if something happens like a snowstorm in april.

Prerequisite

Manual testing steps

Architecture (also see the same diagram in Wiki)

The 3 rounded colored boxes represent the 3 processes you need to run to see the flow of the alert notification being created. image

gitguardian[bot] commented 1 year ago

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [6171532](https://dashboard.gitguardian.com/incidents/6171532?occurrence=89634051) | AMQP Credentials | 8631e61dc74bba1eab8519f3b317909785667a62 | notify-nexus/rabbitmq/utilities/alerts/consumer-alert-pushing.js | [View secret](https://github.com/saladenicoise/SOEN-487-Galactus/commit/8631e61dc74bba1eab8519f3b317909785667a62#diff-a23cfb30d384224efd85c91d76b94193a555d3828a00e671f3edc659b1b3870bR3) | | [6171532](https://dashboard.gitguardian.com/incidents/6171532?occurrence=89634052) | AMQP Credentials | 8631e61dc74bba1eab8519f3b317909785667a62 | notify-nexus/rabbitmq/utilities/generic-producer.js | [View secret](https://github.com/saladenicoise/SOEN-487-Galactus/commit/8631e61dc74bba1eab8519f3b317909785667a62#diff-9b3d3569916c7fbecf5a8ad6b985ac84bcc190593b4c159c793b6965d3afa60eR3) | | [6186110](https://dashboard.gitguardian.com/incidents/6186110?occurrence=89634050) | Bearer Token | 8631e61dc74bba1eab8519f3b317909785667a62 | notify-nexus/scheduler/jobs/alert_scheduler.sh | [View secret](https://github.com/saladenicoise/SOEN-487-Galactus/commit/8631e61dc74bba1eab8519f3b317909785667a62#diff-03ce87e337f023ec776a01690dc0da8e0fc54e38ee8aaf6e414f824e646ac372L3) | | [6186111](https://dashboard.gitguardian.com/incidents/6186111?occurrence=89634049) | Generic High Entropy Secret | 8631e61dc74bba1eab8519f3b317909785667a62 | notify-nexus/notification/createNotification.js | [View secret](https://github.com/saladenicoise/SOEN-487-Galactus/commit/8631e61dc74bba1eab8519f3b317909785667a62#diff-f37053bdfe958708ff49366c439ed65f5d04d9876dede8a4281f5a24eb4789f6R11) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/specifics/amqp_uri#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!