Open mkornipati opened 8 years ago
Hello.
Do you set integration task to null in gretty
configuration? Like:
gretty {
integrationTestTask = null
}
What I see here, that there's a bug if you don't set integrationTestTask
to null in Gretty configuration you actually get it used in AppBeforeIntegrationTestTask if none or falsy is assigned in it.
Yes @saladinkzn. As mentioned in the the description, I tried setting the integrationTestTask as null
or ''
and both not worked.
OK, I'll check it out today
2016-04-14 15:31 GMT+03:00 Mohan Kornipati notifications@github.com:
Yes @saladinkzn https://github.com/saladinkzn. As mentioned in the the description, I tried setting the integrationTestTask as nullor '' and both not worked.
— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/saladinkzn/gretty/issues/10#issuecomment-209915237
Thanks @saladinkzn and just to let you know, currently, as a workaround we are removing the appBeforeIntegrationTest
from integrationTest.dependsOn
and appAfterIntegrationTest
from integrationTest.finalizedBy
project.integrationTest.dependsOn.remove(project.tasks['appBeforeIntegrationTest'])
project.integrationTest.finalizedBy.values.remove(project.tasks['appAfterIntegrationTest'])
Well, I've tested gist and it's working as expected (server is not started when integrationTest task is called using ./gradlew integrationTest
Could you provide a minimal example when appBeforeIntegrationTest is called even when integrationTestTask is set to null?
This is same as created @ https://github.com/akhikhl/gretty/issues/244
I am referring to the "Gretty Configuration" and understood that the default value for
integrationTestTask
isintegrationTest
.We got few projects where we don't need the Tomcat needs to be running for integrationTest Task. and actually name of the integrationTest task is
integrationTest
. I am looking for Gretty Configurations to see, if I can say, I don't need Tomcat start and stop for my "integrationTest" task. Can you point me to right configuration if any.Here are few other observations. I tried setting the
integrationTestTask
asnull
or''
, but I can still see the Tasks -appBeforeIntegrationTest
andappAfterIntegrationTest
getting executed. The reason seems to be becauseappBeforeIntegrationTest.integrationTestTaskAssigned
,appAfterIntegrationTest.integrationTestTaskAssigned
is alwaystrue
and it is not updated to 'false' when I am updating value ofintegrationTestTask
to null or empty string?