Closed flyher closed 6 months ago
The point of this check is when rule type is Auto, then the custom Urls will be used if selected from combo. This change can cause issues with empty urls. Sorry this is by design even though it's not very obvious!
Since Auto Theme is selected, it shouldn't continue to check for user-defined settings. The Theme Settings module defines too many parameters, needs an update to reduce them for subsequent maintenance.
There is no Auto theme, Auto means either Light or Dark themes will be used. That means settings for both of these themes needs to be correct and thus the validation happens.
Sorry but this PR can cause invalid URLs in themes
I understood your explanation, I was the one who misinterpreted the 'auto' here.
Clicking Save will trigger an error when the user forgets to fill in the custom link and switches to another theme.