search

salarcode / SmartProxy

Firefox/Chrome browser extension. SmartProxy will automatically enable/disable proxy for the sites you visit, based on customizable patterns.
https://addons.mozilla.org/en-US/firefox/addon/smartproxy/
GNU General Public License v3.0
1.86k stars 113 forks source link

ignore link check when user has not selected a custom theme #347

Closed flyher closed 6 months ago

flyher commented 6 months ago

Clicking Save will trigger an error when the user forgets to fill in the custom link and switches to another theme.

ignore theme link check

salarcode commented 6 months ago

The point of this check is when rule type is Auto, then the custom Urls will be used if selected from combo. This change can cause issues with empty urls. Sorry this is by design even though it's not very obvious!

flyher commented 6 months ago

Since Auto Theme is selected, it shouldn't continue to check for user-defined settings. The Theme Settings module defines too many parameters, needs an update to reduce them for subsequent maintenance.

salarcode commented 6 months ago

There is no Auto theme, Auto means either Light or Dark themes will be used. That means settings for both of these themes needs to be correct and thus the validation happens.

Sorry but this PR can cause invalid URLs in themes

flyher commented 6 months ago

I understood your explanation, I was the one who misinterpreted the 'auto' here.