salarcode / SmartProxy

Firefox/Chrome browser extension. SmartProxy will automatically enable/disable proxy for the sites you visit, based on customizable patterns.
https://addons.mozilla.org/en-US/firefox/addon/smartproxy/
GNU General Public License v3.0
1.93k stars 117 forks source link

The feature called "Use proxy for tab/source" does not work. #403

Closed roman90sv closed 4 weeks ago

roman90sv commented 1 month ago

Description

The settings say that if the rule matches the tab URL, then all network requests will be forwarded to the proxy (for this active tab). However, this is not true.

I added the domain "youtube.com" to the rules using the add-on button on the browser panel. But the browser continued to make unsuccessful attempts to directly connect to other YouTube video hosting domains. For example: ggpht.com, ytimg.com, etc. These domains are displayed in the list of failed requests. And also, images in the "communities" of YouTube channels are not displayed. If you change the proxy profile to "Always on", then there are no errors accessing the mentioned domains and the images are displayed in the communities. This means that the "Use proxy for tab/source" function really does not work in Firefox.

ps: If I have to create rules with all YouTube related domains, then it will be more logical to go back to using PAC file.

Video

Steps to Reproduce

1) Visited youtube. 2) Added domain "youtube.com" to the rules using the add-on button on the browser panel. 3) Browser continued to make unsuccessful attempts to directly connect to other YouTube video hosting domains (which are blocked by the censor). Despite the fact that function "Use proxy for tab/source" is active.

Which browsers did you test this on?

Firefox

Affected browser versions

130.0.1

Affected SmartProxy versions

1.6

Screenshots of the problems or steps to reproduce

No response

Any additional context

No response

salarcode commented 4 weeks ago

What you see there is list of failed requests, which indicates the request has failed or will be failed if no response comes back. That does not mean that requests requests are not going through proxy. It means something wrong with the request, could be bad proxy problem too being slow.

To check whether requests are going through proxy or not use "Proxyable Resources" and what the results

image

brawaru commented 4 weeks ago

@salarcode I'm using Proxyable Resources, and opening x.com, only everything to x.com domain gets matched and proxied, all other requests, like ones to abs.twimg.com, report ➖ No Proxy, ➖ No Match. And on https://www.ipify.org/, adding www.ipify.org domain rule, request to API on the tab is fetched without proxy, giving you a non-proxy IP.

roman90sv commented 4 weeks ago

As you can see in the screenshots, the add-on does not proxy i.ytimg.com, gstatic.com, play.google.com (etc) on YouTube pages. The video shows that images are not loading in YouTube communities. This is clear evidence that the add-on does not route YouTube related domains.

When I use PAC with all YouTube related domains I have no problems. I have a personal proxy server. It is fast. And My proxy works through trojan protocol, which is invulnerable to DPI.

roman90sv commented 4 weeks ago

1 Снимок экрана от 2024-09-29 17-55-04 Снимок экрана от 2024-09-29 17-31-02

salarcode commented 4 weeks ago

Confirming the issue thanks to @brawaru a fix will come out soon

roman90sv commented 3 weeks ago

The bug has been fixed in version 1.6.1.