Closed salarkhan closed 10 years ago
Wondering how the pre-commit hook is supposed to call these ./pear executables...
Here's the old cycle team
function that I'd like to shove into this PR as well.
sed -i '' -e '1d' $team
echo $committer >> $team
I guess before we get deeper into this, we should agree that the committer is always gonna be line 1 and the author is always gonna be line 2. ( Or the other way around )
So I just realized that the author is the one who gets the credit -- makes me think we should have that be line 1 && committer as line 2. Lemme know what ya think
:+1: to merge with my tiny change
Still need to address 2 issues:
Addressed 'em both. Merrrrrjjjjjeeeng
Addressed em both. Time to meeeeerrrrjjjjj
I dont know how to Github
meeeeeeeeeeeeeeerrjjjjed
one the "committer is always gonna be line 1 and the author is always gonna be line 2" thing. i don't really care, though looking at your screenie i think it might make more sense the other way as that is how github is listing them on the commit logs. that is to say author is on the top the way github has it currently. Should we follow their convention?
edit: i wrote this before github refreshed the page. we agree apparently.
Wondering if we should export team_text_location if we end up using it a lot...?
Gotta run for the Brazil/Colombia game, you can finish this off if you have time