salarkhan / git-pear

swap credentials after each commit
3 stars 0 forks source link

Get committer & author email #13

Closed salarkhan closed 10 years ago

salarkhan commented 10 years ago

Wondering if we should export team_text_location if we end up using it a lot...?

Gotta run for the Brazil/Colombia game, you can finish this off if you have time

salarkhan commented 10 years ago

Wondering how the pre-commit hook is supposed to call these ./pear executables...

Here's the old cycle team function that I'd like to shove into this PR as well.

    sed -i '' -e '1d' $team
    echo $committer >> $team

I guess before we get deeper into this, we should agree that the committer is always gonna be line 1 and the author is always gonna be line 2. ( Or the other way around )

salarkhan commented 10 years ago

screen shot 2014-07-06 at 8 20 18 pm

So I just realized that the author is the one who gets the credit -- makes me think we should have that be line 1 && committer as line 2. Lemme know what ya think

supertopher commented 10 years ago

:+1: to merge with my tiny change

salarkhan commented 10 years ago

Still need to address 2 issues:

salarkhan commented 10 years ago

Addressed 'em both. Merrrrrjjjjjeeeng

salarkhan commented 10 years ago

Addressed em both. Time to meeeeerrrrjjjjj

salarkhan commented 10 years ago

I dont know how to Github

meeeeeeeeeeeeeeerrjjjjed

supertopher commented 10 years ago

one the "committer is always gonna be line 1 and the author is always gonna be line 2" thing. i don't really care, though looking at your screenie i think it might make more sense the other way as that is how github is listing them on the commit logs. that is to say author is on the top the way github has it currently. Should we follow their convention?

edit: i wrote this before github refreshed the page. we agree apparently.