search

salass00 / smb2fs

SMB2 file system client
GNU General Public License v2.0
26 stars 6 forks source link

Fails to parse URL if contained password in URL has a '?' question mark #1

Open migthymax opened 1 year ago

migthymax commented 1 year ago

Fails to parse URL if contained password in URL has a '?' question mark. A quick look into [libsmb2-git](https://github.com/salass00/smb2fs/tree/09730a601af5da3635e76e58a3aeab82d2cfb1f3/libsmb2-git)/[lib](https://github.com/salass00/smb2fs/tree/09730a601af5da3635e76e58a3aeab82d2cfb1f3/libsmb2-git/lib)/init.c reveals at line 204, that a possible the question in a supplied password, will be interpreted as delimiter for additional arguments.

salass00 commented 1 year ago

For now commit https://github.com/salass00/smb2fs/commit/bf6c8a7719c61464a0991836cf1533b5772af476 adds optional separate USER and PASSWORD arguments that can be used if username and/or password contain characters not compatible with the smb:// URL format.