search

salat / salat

Salat is a simple serialization library for case classes.
https://github.com/salat/salat
Other
483 stars 106 forks source link

Support for Mongo 3.6+ #209

Open rcaloras opened 6 years ago

rcaloras commented 6 years ago

Hey @noahlz!

Is there any work or plans to upgrade to support newer versions of Mongo? Based on compatibility charts, believe Casbah only goes up to 3.4. Has anyone gotten Salat working with 3.6+ or is there plans to move to https://github.com/mongodb/mongo-scala-driver?

Thanks for maintaining over the years!

noahlz commented 6 years ago

Thank you for bringing this to my attention. In fact, I am employed at Novus and we have not used Mongo here for years (although we do still have code that uses Salat for json serialization), so I am not actively developing Salat or keeping pace with the Mongo ecosystem. My role is more "steward" than maintainer.

I see that Casbah is more-or-less deprecated - its README states that mongo-scala-driver is a "more modern" implementation. This implies that Casbah will no longer be supported for newer versions of Mongo (unless someone rolls up their sleeves and does it). If Casbah was updated to support 3.6+, Salat easily could as well.

Salat was built on top of Casbah (also originally developed at Novus, see below *), so I imagine migrating Salat to a new mongo-scala-driver would be a pretty big change, i.e. worthy of 2.0.

All that said, if someone wants to do the work of migrating Salat to mongo-salat-driver, I will happily devote free time to code review, ensuring unit tests pass, and so on. This would certainly be a 2.0 release.

(* Fun side-note the LICENSE file for Casbah still says (c) 2010 Novus Partners - someone should really get on updating that!)

Thanks!

rcaloras commented 6 years ago

@noahlz Thanks for the detailed response! I don't think I'll have the bandwidth to do the migration, but may be forced to figure something out for one of my projects that's using salat.