added carrier IP to android and ios

salbahra / cordova-plugin-networkinterface

Provide a method for Cordova applications to retrieve the device IP Address.

http://albahra.com/projects

72 stars 51 forks source link

added carrier IP to android and ios #17

Closed winfinit closed 7 years ago

winfinit commented 7 years ago

added ability to get carriers IP

winfinit commented 7 years ago

there is ionic 2 demo app that can be used to demo this functionality: https://github.com/winfinit/ionic2-demo-cordova-plugin-networkinterface

salbahra commented 7 years ago

Can we keep the old getIPAddress method in place which just uses getWiFiAddress instead of breaking support for the previous method?

salbahra commented 7 years ago

Not sure if the commit I made was done to your actual master branch (not sure why I am allowed to do that), sorry. However, I think that simple fix is all that's needed to make this a good solution moving forward.

salbahra commented 7 years ago

Ah awesome! Okay I think we can merge this in then, I see no issues.