salcode / bootstrap-genesis

WordPress Genesis Child Theme setup to use Bootstrap, Sass, and Grunt
MIT License
184 stars 63 forks source link

Ubermenu not replacing collapsed Bootstrap menu #105

Closed eSaner closed 8 years ago

eSaner commented 8 years ago

I've installed Ubermenu, which replaces the Bootstrap menu and works as expected until <768px, when the collapsed Bootstrap menu appears in place of Ubermenu.

Also at <768px, expanding the the Bootstrap menu shows the collapsed Ubermenu button, but the Ubermenu button does not work.

Should this be happening? How can I disable the responsive/collapsed Bootstrap menu?

Ubermenu >=768px: ubermenu

Bootstrap menu <768px: bootstrap-menu

Bootstrap menu expanded <768px: bootstrap-menu-expanded

salcode commented 8 years ago

@dustyndoyle have you experienced this issue?

salcode commented 8 years ago

@eSaner thanks for bringing this to my attention.

It looks like the check introduced in #6 looks for the class UberMenuStandard, which is not detecting the latest version of the UberMenu plugin.

Changing UberMenuStandard to UberMenu in this check appears to resolve the problem (this code appears in lib/nav.php). I'd recommend trying this, it resolved the issue in my local install. Please let me know if this does not resolve the issue for you.

By the way, great bug report, the screenshots were particularly helpful in understanding the problem.

Thanks.

eSaner commented 8 years ago

Thanks for the quick response! That fixed it.

salcode commented 8 years ago

Awesome, thanks for the follow up :+1:

dustyndoyle commented 8 years ago

Yes, I had to change the class to Ubermenu on the latest site I used it for. That fixed it for me, it looks like ubermenu 3 changed their class name On Oct 6, 2015 10:04 AM, Sal Ferrarello notifications@github.com wrote:@dustyndoyle have you experienced this issue?

—Reply to this email directly or view it on GitHub.

salcode commented 8 years ago

Thanks @dustyndoyle, this is now resolved in develop