salcode / bootstrap-genesis

WordPress Genesis Child Theme setup to use Bootstrap, Sass, and Grunt
MIT License
184 stars 63 forks source link

Should we add default Genesis Column Classes? #120

Open salcode opened 8 years ago

salcode commented 8 years ago

Plugins like Bill Erickson's Genesis Grid expect the presence of Genesis CSS classes for columns (e.g. .one-half, .one-third, etc.).

These classes actually come from an old version of Bootstrap and are no longer included in Bootstrap.

The CSS is listed on http://my.studiopress.com/tutorials/content-column-classes/ (login required)

By adding them to this started theme, it would allow plugins or code snippets expecting the presence of these CSS classes to be used.

On the other hand, I want to minimize the amount of CSS we add.

Is it worth adding this CSS to the base code?