search

salcode / bootstrap-genesis

WordPress Genesis Child Theme setup to use Bootstrap, Sass, and Grunt
MIT License
184 stars 63 forks source link

Remove duplicate featured images on blog page #35

Closed codenameEli closed 9 years ago

codenameEli commented 9 years ago

On the backend of WordPress, if you set "Include the Featured Image" under Genesis->Theme Settings, you will get the Genesis Archive Featured Image and the archive-featured-image.

If this setting is enabled, the archive-featured-image should not display.

Screenshot of setting the image in the backend screenshot 2015-02-14 11 41 31

Screenshot of display on blog page screenshot 2015-02-14 11 41 52

salcode commented 9 years ago

@codenameEli you're right this definitely needs to be improved, thank you for bringing it up. While I agree your patch makes it better than the current state, I think it can be improved further.

Current Behavior

Bootstrap Genesis puts the featured image before .entry-header regardless of the Genesis Theme Settings (and activating "Include the Featured Image" results in the featured image displayed twice).

Default Genesis Behavior

Activating "Include the Featured Image" results in the featured image displaying inside .entry-content (after the .entry-header)

I really prefer the Featured Image before .entry-header but agree we should integrate better with Genesis core on this item.

Possible Options

  1. Disable the Bootstrap Genesis Featured Image if the Genesis Theme Setting "Include the Featured Image" is on. Definitely an improvement but I think we can integrate even further. I believe the whole reason we're not using the default behavior is Genesis puts the featured image inside .entry-content, which is after the .entry-header.
  2. Remove the custom Featured Image functionality and use the default Genesis behavior (again, I'm not a fan of where the Featured Image displays)
  3. (Recommended) We move where the built-in Featured Image displays by unhooking it from displaying in .entry-content and instead hooking in before the .entry-header. This way we could still use the Genesis Theme Setting "Include the Featured Image".

Final note, is it possible you posted the wrong image with your original issue?

codenameEli commented 9 years ago

Thanks for the notes, I agree with option 3. I will work on that change and see what I come up with. Were you expecting something like this... image