search

salcode / bootstrap-genesis

WordPress Genesis Child Theme setup to use Bootstrap, Sass, and Grunt
MIT License
184 stars 63 forks source link

Add Option For All Layouts #45

Closed bryanwillis closed 9 years ago

bryanwillis commented 9 years ago

This is my first time using sass/scss and less. I tested with less and it works. It could probably be shortened and optimized for different media queries. Here is the less version that works for sure. https://gist.github.com/bryanwillis/08b64ac92a2bf714417b#file-genesis-bootstrap-layouts-less. For this to work genesis_after_content_sidebar_wrap() has to be moved inside content_sidebar_wrap. See page.php in root directory or https://gist.github.com/bryanwillis/08b64ac92a2bf714417b#file-bootstrap-genesis-template-php. I tried various other methods like filtering the classes or adding/rearranging hooks as well as genesis_site_layout(), but after unnecessary hassle messing with the php, css seemed like the simplest approach. It can be seen live here http://runningblog.wpengine.com/content-sidebar/ by clicking the layout submenus under main nav.

salcode commented 9 years ago

I'm getting Sass error

Warning: /Users/sal/vagrant-local/www/genesis/htdocs/wp-content/themes/bootstrap-genesis/css/sass/supporting/layout:5: invalid name in @include directive
 Use --force to continue.

What are you using to compile less? Can it be used to compile Sass instead?

salcode commented 9 years ago

Since we're addressing this at the markup level by adding the appropriate classes, I'm going to close this PR.