salcode / bootstrap-genesis

WordPress Genesis Child Theme setup to use Bootstrap, Sass, and Grunt
MIT License
184 stars 63 forks source link

Fix Primary nav margins when both menus enabled #65

Closed bryanwillis closed 9 years ago

bryanwillis commented 9 years ago

When both primary and secondary menus are enabled, there is a 20px gap between the two menus. Bootstrap adds a margin to the bottom of the menu to create spacing between the menu and the page content, but when two menus are stacked this creates unnecessary gap between the two menus. This seems like a lot of code to add to change just one css rule, there is probably a smarter way to do this that I'm not thinking of.

bryanwillis commented 9 years ago

Actually coming back to this I realize there is a way easier solution by just using the adjacent sibling css selector. See here: https://github.com/salcode/bootstrap-genesis/pull/66

salcode commented 9 years ago

I agree with you that #66 seems like a cleaner solution. I'm going to close this PR.