search

salcode / bootstrap-genesis

WordPress Genesis Child Theme setup to use Bootstrap, Sass, and Grunt
MIT License
184 stars 63 forks source link

Alternative for fixing layered navigation styles #66

Closed bryanwillis closed 9 years ago

bryanwillis commented 9 years ago

Easier solution for fixing navigation margins and dropdown z-index

bryanwillis commented 9 years ago

Before: Before

After: After

salcode commented 9 years ago

I like this idea. A couple of notes,

1) To get nav.scss to work, I needed to add

@import "supporting/nav";

in css/sass/style.scss (this file loads all the other Sass files)

2) I changed the CSS to use Bootstrap variables for the values. e.g.

margin-top: -20px;

became

margin-top: -1 * $navbar-margin-bottom;

the benefit here is if we add 

$navbar-margin-bottom: 80px;

in css/sass/supporting/variables.scss the margin on the bottom of all the navbars will increase to 80px but our two navs will still stay properly placed in relation to each other.

This are little things but I wanted to let you know about the changes I made.

Thanks for the patch, this is a definite improvement.

salcode commented 9 years ago

Merged in 8071cb1